Closed
Conversation
v8-compile-cache breaks dynamic import() in this process.
electron-serve is ESM in newer versions, which breaks CommonJS require(). Kick off electron-serve initialization at module load and await it during init so the webui:// scheme is registered before we create windows / load URLs.
Prep for updating i18next-icu: newer versions are ESM-only, so require() breaks. Dynamic import works with both CommonJS and ESM.
Follow up to the ESM loader change so we can use the newer electron-serve release.
Use newer i18next-icu which requires intl-messageformat >=10.3.3.
We no longer use it (dynamic import breaks with it enabled).
Pin electron-builder to match the app-builder-lib patch and keep installs deterministic. The patch keeps the schema tweak that allows azureSignOptions.publisherName to be a string.
Keep patching dependencies during postinstall with the current patch-package release.
Keep electron-store on a known CJS-compatible release.
Refresh common dev tools (cross-env, dotenv, got, shx, sinon, tmp, semver-regex).
Keep fs-extra current.
Align address handling with the multiaddr stack used by newer IPFS tooling.
Keep startup responsive while RPC endpoint finishes warming up.
If startup returns without a peer id, retry id() once with a short timeout. If that still fails, continue startup instead of treating it as a blocker. This keeps the UI and tray usable, including when a configured custom binary path is valid but the binary does not actually start and the user needs to switch back to the bundled binary.
This avoids drawing in deprecated js-ipfs-era dependencies.
Allow protocol handlers to use gateway base values that are already plain URLs, in addition to multiaddr-form inputs.
If the WebUI fails to load, log an Error with the load message and code so the issue is easier to diagnose. Also ensure failures are logged clearly even when the value is not an Error object.
Remove afterSign from the shared electron-builder config so Linux builds do not print the no-signing warning. Keep notarization active for macOS release builds by passing afterSign only on the macOS CI build.
Adjust the app-builder-lib patch so Linux builds avoid the DEP0190 child-process warning while keeping Windows behavior unchanged.
Ignore the known DEP0180 warning from Electron's ASAR internals so runtime logs stay focused on actionable issues.
Use a local boolean compatibility shim via npm overrides so installs stop pulling the deprecated boolean package.
Use a local lodash.isequal compatibility shim via npm overrides so installs stop pulling the deprecated lodash.isequal package.
Update dotenv to the latest patch release in the current major line.
Use a local helper for the addAll result and drop the direct it-last package.
Use main-window visibility events for blank and restore routing, and align loadURL dedupe with the current WebUI URL before skipping navigation.
Try to focus WebUI contents on window show to keep keyboard interaction consistent after reopen.
Move WebUI URLs off the '-' host and match by origin so internal hash navigation is not rewritten by host-splitting behavior.
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the navigation bug, where the first click in the UI would just do a refresh of the status page and only the second click on navigation items works.
Linting is expected to fail, since #3066 introduced a new linter. :)
Testing: I can only test on Linux, and I tested the core functionality of the app with Electron
39.5.1.Note: This commit contains the changes of PR #3048, #3049, #3050, #3051, #3052, #3053, #3054, #3055, #3056, #3058, #3059, #3060, #3061, #3062, #3063, #3064, #3065, #3066, #3067, #3068, #3069, #3070, #3071, #3072, #3073, #3074, #3075, #3076, #3077, #3078, #3079, #3080, #3081, #3082, #3083, #3084, #3085, #3086, #3087, #3088, #3089, #3090, #3091, #3092, #3093, #3094, #3095, #3096, #3098, #3099, #3100, #3101, #3102, #3103, #3104, #3105, #3106, #3107, #3108, #3110 and #3111 as soon as they are accepted, I'll remove those commits.